Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields required to support self-managed certificates #37

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Add fields required to support self-managed certificates #37

merged 1 commit into from
Apr 7, 2022

Conversation

impl
Copy link
Contributor

@impl impl commented Apr 1, 2022 •
edited
Loading

Description

When programmatically managing self-managed certificates, i.e. by requesting the /verify endpoint in code, the caller needs needs to know the values of the origin domain name and the cname-api-key header to set up the reverse proxy correctly. This change simply adds those two fields to the CustomDomain struct.

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@impl impl requested a review from a team as a code owner April 1, 2022 22:55
@impl impl mentioned this pull request Apr 2, 2022
Merged
8 tasks
sergiught
sergiught approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @impl ! 🥳 Great addition!

We'll aim at making a release by the end of this week so we can reference the new version within the terraform provider as well.

@sergiught
Copy link
Contributor

Tests will fail cuz this is coming from a fork but they pass locally:

image

We'll try to open these for forks as well soon, but there's some work we need to do first.

@sergiught sergiught merged commit 8e4e76e into auth0:main Apr 7, 2022
@impl impl deleted the custom-domain-self-managed-certificates branch April 8, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiught sergiught sergiught approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@impl @sergiught